fix: error in 'Process and Ingest Web Pages' under 'Add URLs to the Knowledge Base' (CWYD) #1816
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces several improvements and updates across various files and components, focusing on infrastructure naming conventions, frontend enhancements, backend functionality, and configuration management. The most important changes include the addition of a
.dockerignore
file, updates to environment variables, enhancements to frontend components, backend validation improvements, and the introduction of standardized abbreviations for resource naming.Infrastructure Updates:
infra/abbreviations.json
to define standardized abbreviations for Azure resource naming conventions, ensuring consistency across infrastructure.infra/main.bicep
to use abbreviations for naming Azure resources, such aspsql-
for PostgreSQL andoai-
for OpenAI services. (Fb0606efL10R10, [1] [2] [3] [4] [5] [6]miName
parameter ininfra/core/security/managed-identity.bicep
to allow more flexible naming.Backend Enhancements:
code/backend/pages/01_Ingest_Data.py
by adding checks for valid URLs and displaying error messages when none are provided.code/backend/pages/04_Configuration.py
to use a dialog-based approach, simplifying the user experience and improving clarity.Frontend Enhancements:
code/frontend/src/components/ChatHistoryListItemCell/ChatHistoryListItemCell.tsx
using Fluent UI'sTooltipHost
, providing better accessibility and context for truncated chat titles. [1] [2] [3] [4]TooltipHost
inChatHistoryListItemCell.test.tsx
to facilitate testing of tooltip functionality.Environment Variable Updates:
AZURE_COSMOSDB_ACCOUNT_KEY
to.env.sample
to support CosmosDB integration.General Improvements:
.dockerignore
file to exclude unnecessary files and directories from Docker builds, improving container efficiency and security.Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information